Add SystemError.Is for errors.Is context matching (#934) - #934
Open
justinhwang wants to merge 1 commit into
Open
Add SystemError.Is for errors.Is context matching (#934)#934justinhwang wants to merge 1 commit into
justinhwang wants to merge 1 commit into
Conversation
SystemError now implements Is so errors.Is(err, context.DeadlineExceeded) and errors.Is(err, context.Canceled) match tchannel timeout and cancellation errors respectively. Matching is keyed on the wire error code, so timeouts and cancellations from non-Go peers match too. This also matches remote and relay timeouts, so callers that must distinguish a local context expiry from a downstream one should still check ctx.Err(). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
justinhwang
force-pushed
the
system-error-is-context
branch
from
August 4, 2026 17:48
499567e to
a55fc1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SystemError now implements Is so errors.Is(err, context.DeadlineExceeded) and errors.Is(err, context.Canceled) match tchannel timeout and cancellation errors respectively. Matching is keyed on the wire error code, so timeouts and cancellations from non-Go peers match too. This also matches remote and relay timeouts, so callers that must distinguish a local context expiry from a downstream one should still check ctx.Err().
Also fix CI: bump actions/checkout (v2 -> v7) and actions/setup-go (v5 -> v7), run checkout before setup-go with cache-dependency-path so module caching works, drop the dead glide actions/cache step (no glide.lock/vendor in the repo), and exclude stdlib internal/synctest from check_no_test_deps (Go 1.25+ pulls it into prod deps and its name trips the test grep, as internal/testlog already does).